fix(parser): preserve double quotes inside $() in double-quoted strings#826
Merged
fix(parser): preserve double quotes inside $() in double-quoted strings#826
Conversation
Closes #803 — single-quoted strings inside command substitutions within double-quoted word segments now preserve embedded double quotes. Root cause: the inline double-quote handler in read_word() didn't track $(...) command substitutions, so a " inside a single-quoted string within $() was treated as the closing delimiter of the outer double-quoted segment. Fix: when encountering $( inside an inline double-quoted segment, delegate to read_command_subst_into() which properly handles nested quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_word()inline double-quote handler to properly track$()command substitutions$(is encountered inside a double-quoted word segment, delegate toread_command_subst_into()which handles nested quotes (single quotes, double quotes, escapes)"inside a single-quoted string within$()was misinterpreted as the closing delimiter of the outer double-quoted segmentTest plan
cmdsub_preserves_double_quotes_in_single_quotes—x="$(echo '{"a":1}')"preserves"cmdsub_preserves_double_quotes_simple—y="$(echo 'say "hello" please')"preserves"cmdsub_without_outer_quotes_works— baseline without outer quotes still worksCloses #803